Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bid model + Create Bid + Active landing page bid response #99

Merged
merged 17 commits into from
Oct 25, 2021
Merged

Bid model + Create Bid + Active landing page bid response #99

merged 17 commits into from
Oct 25, 2021

Conversation

vikinatora
Copy link
Contributor

  1. Add bid model (may change in the future)
  2. Add temp create bid functionality which will be used until the scraping functionality is done
  3. Upgrade the active landing page response to feature bids and other active auctions info

@vikinatora
Copy link
Contributor Author

Let me know what you think guys.
cc: @boris-bonin

alexandrumatei36
alexandrumatei36 reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@alexandrumatei36 alexandrumatei36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some quick comments. I will take a closer look tomorrow morning when I get back to work

@alexandrumatei36
Copy link
Contributor

cc @johnkcr take a look at this PR to get familiar with other parts of the app

@vikinatora vikinatora mentioned this pull request Oct 20, 2021
Open
@vikinatora
Copy link
Contributor Author

Also cc: @taskudis can also start getting to know the codebase

@vikinatora
Copy link
Contributor Author

vikinatora commented Oct 20, 2021 •
edited
Loading

@alexandrumatei36 We need to think of a way to change how the auction is queried or the link of the page in the FE as I just got into a bug where after you change your display name in the profile page, the link to the auction doesn't get updated and it can't find the auction when you open the landing page

Updating all the auction links on profile change is one way but I don' think it's optimal

alexandrumatei36
alexandrumatei36 suggested changes Oct 20, 2021
View reviewed changes
@alexandrumatei36
Copy link
Contributor

@alexandrumatei36 We need to think of a way to change how the auction is queried or the link of the page in the FE as I just got into a bug where after you change your display name in the profile page, the link to the auction doesn't get updated and it can't find the auction when you open the landing page

Updating all the auction links on profile change is one way but I don' think it's optimal

@vikinatora The auction link doesn't have to contain the user display name. It should be stored separately and the auction url computed piece by piece

@vikinatora
Copy link
Contributor Author

  • Add bids response to my active and past auctions endpoints

@taskudis taskudis merged commit ff2e33f into dev Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrumatei36 alexandrumatei36 Awaiting requested review from alexandrumatei36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikinatora @alexandrumatei36 @taskudis